web/cypress/e2e/perses/99.coo_rbac_perses_user1.cy.ts (1)

66-67: Extract the two-step Perses navigation into one helper.

This exact sequence now appears across all 99.coo_rbac_perses_user{1..6}.cy.ts specs. Wrapping it in something like nav.sidenav.openPersesDashboards() would keep future route fixes in one place.

♻️ Suggested cleanup

-    nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
-    nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
+    nav.sidenav.openPersesDashboards();

// web/cypress/views/nav.ts
openPersesDashboards: () => {
  nav.sidenav.clickNavLink(['Observe', 'Dashboards']);
  nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
},

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/e2e/perses/99.coo_rbac_perses_user1.cy.ts` around lines 66 - 67,
Extract the repeated two-step navigation into a single helper method on the nav
view: create a function named openPersesDashboards (e.g.,
nav.sidenav.openPersesDashboards) that calls
nav.sidenav.clickNavLink(['Observe', 'Dashboards']) then
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']), and replace the
two-line sequences in all 99.coo_rbac_perses_user{1..6}.cy.ts specs with a
single call to nav.sidenav.openPersesDashboards() so future route changes are
centralized.

web/cypress/views/perses-dashboards-create-dashboard.ts (1)

65-69: Drop the new fixed pause before clicking Cancel.

The button is already gated by should('be.visible'), so the extra cy.wait(2000) only adds suite latency and still leaves the interaction time-based instead of state-based.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/views/perses-dashboards-create-dashboard.ts` around lines 65 -
69, In createDashboardDialogCancelButton remove the pre-click fixed pause (the
cy.wait(2000) immediately before the .byPFRole('dialog')...click call) and rely
on the existing should('be.visible') assertion for a state-based interaction;
leave the rest of the method unchanged so the click uses the visibility guard
instead of a time-based wait.

web/cypress/support/perses/99.coo_rbac_perses_user1.cy.ts (1)

479-494: ⚠️ Potential issue | 🟠 Major

Use the exact generated dashboard name for delete cleanup (not a shared prefix).

Line 480 and Line 493 still filter by 'Testing Dashboard - UP', which can match multiple leftover dashboards and make delete/counter assertions flaky.

🛠️ Suggested fix

+let createdDashboardName = '';

 it(`5.${perspective.name} perspective - Create Dashboard with panel groups, panels and variables`, () => {
-  let dashboardName = 'Testing Dashboard - UP ';
-  let randomSuffix = Math.random().toString(5);
-  dashboardName += randomSuffix;
+  createdDashboardName = `Testing Dashboard - UP ${Math.random().toString(36).slice(2, 10)}`;
@@
-  persesCreateDashboardsPage.enterDashboardName(dashboardName);
+  persesCreateDashboardsPage.enterDashboardName(createdDashboardName);
@@
 });

 it(`9.${perspective.name} perspective - Delete dashboard`, () => {
+  expect(createdDashboardName, 'created dashboard name').to.not.equal('');
@@
-  listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
+  listPersesDashboardsPage.filter.byName(createdDashboardName);
@@
-  listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
+  listPersesDashboardsPage.filter.byName(createdDashboardName);
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/support/perses/99.coo_rbac_perses_user1.cy.ts` around lines 479 -
494, The test is filtering and deleting using the shared prefix 'Testing
Dashboard - UP', which can match multiple dashboards and make assertions flaky;
update both calls to listPersesDashboardsPage.filter.byName(...) (lines
filtering before delete and final verify) to use the exact generated dashboard
name variable used when the dashboard was created (e.g., createdDashboardName or
dashboardName) instead of the hardcoded prefix, ensuring
listPersesDashboardsPage.countDashboards(...) and subsequent delete steps
(clickKebabIcon, clickDeleteOption, deleteDashboardDeleteButton, emptyState)
operate on the single intended dashboard.

web/cypress/support/perses/01.coo_list_perses_admin_namespace.cy.ts (1)

73-76: Extract repeated “return to Dashboards (Perses)” navigation into one helper.

The same two-step nav sequence is duplicated in two places. A small local helper will reduce drift and keep future fixes in one place.

♻️ Suggested refactor

 export function testCOOListPersesNamespace(perspective: PerspectiveConfig) {
+  const returnToPersesDashboards = () => {
+    nav.sidenav.clickNavLink(['Observe', 'Alerting']);
+    nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
+    listPersesDashboardsPage.shouldBeLoaded();
+  };

   it(`1.${perspective.name} perspective - List Dashboards (Perses) page`, () => {
@@
-    nav.sidenav.clickNavLink(['Observe', 'Alerting']);
-    nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
+    returnToPersesDashboards();

     cy.log(`1.11. Click on a dashboard`);
@@
   it(`2.${perspective.name} perspective - Duplicate from a project to another, Rename and Delete`, () => {
@@
-    nav.sidenav.clickNavLink(['Observe', 'Alerting']);
-    nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']);
+    returnToPersesDashboards();

Also applies to: 125-126

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/support/perses/01.coo_list_perses_admin_namespace.cy.ts` around
lines 73 - 76, The duplicated two-step navigation using
nav.sidenav.clickNavLink(['Observe', 'Alerting']) followed by
nav.sidenav.clickNavLink(['Observe', 'Dashboards (Perses)']) should be extracted
into a small helper (e.g., returnToDashboardsPerses or goToDashboardsPerses) and
called from both places where it repeats; update the calls that currently
perform the two-step sequence (the lines invoking nav.sidenav.clickNavLink with
['Observe','Alerting'] and ['Observe','Dashboards (Perses)']) to a single call
to the new helper to centralize the behavior and reduce duplication.

web/cypress/views/perses-dashboards-create-dashboard.ts (1)

67-69: Replace hard-coded waits with explicit UI state assertions.

Lines 67 and 69 use arbitrary 2-second delays that slow tests and mask synchronization issues. The pre-click wait (line 67) is redundant since the cancel button already checks .should('be.visible') before clicking. Replace both waits with assertions that verify the dialog closes or expected state changes—for example, wait for the dialog to disappear or confirm that submit/cancel actions complete.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/views/perses-dashboards-create-dashboard.ts` around lines 67 -
69, Replace the two hard-coded cy.wait(2000) calls by relying on explicit UI
assertions: keep the existing
cy.byPFRole('dialog').find('button').contains('Cancel').should('be.visible').click({
force: true }) but remove the pre-click wait, and after the click assert the
dialog has closed (e.g., cy.byPFRole('dialog').should('not.exist') or
should('not.be.visible')) or assert the expected post-cancel state (a specific
element appears/disappears or URL changes) so the test synchronizes on UI state
instead of timeouts; update the code referencing cy.byPFRole('dialog') and the
Cancel button accordingly.

web/cypress/support/perses/99.coo_rbac_perses_user1.cy.ts (1)

479-494: ⚠️ Potential issue | 🟠 Major

Delete flow is still prefix-based and flaky; use the exact generated dashboard name.

This still depends on 'Testing Dashboard - UP' prefix matching and can target the wrong row if stale dashboards exist. Please persist the exact generated name from the create test and delete by that exact value.

Proposed fix

 export function testCOORBACPersesTestsDevUser1(perspective: PerspectiveConfig) {
+  let createdDashboardName: string | undefined;

   it(`5.${perspective.name} perspective - Create Dashboard with panel groups, panels and variables`, () => {
     let dashboardName = 'Testing Dashboard - UP ';
     let randomSuffix = Math.random().toString(5);
     dashboardName += randomSuffix;
+    createdDashboardName = dashboardName;
     ...
   });

   it(`9.${perspective.name} perspective - Delete dashboard`, () => {
     ...
-    listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
+    expect(createdDashboardName, 'created dashboard name from test 5').to.be.a('string');
+    listPersesDashboardsPage.filter.byName(createdDashboardName as string);
     listPersesDashboardsPage.countDashboards('1');
     ...
-    listPersesDashboardsPage.filter.byName('Testing Dashboard - UP');
+    listPersesDashboardsPage.filter.byName(createdDashboardName as string);
     listPersesDashboardsPage.countDashboards('0');
   });
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/support/perses/99.coo_rbac_perses_user1.cy.ts` around lines 479 -
494, The delete flow currently filters by the static prefix 'Testing Dashboard -
UP' which is flaky; update the test to use the exact generated dashboard name
saved during the create step (store it as a Cypress alias or test context
variable) and use that value when calling
listPersesDashboardsPage.filter.byName(generatedName) and
listPersesDashboardsPage.countDashboards(expectedCount); ensure the exact name
is used for the kebab/delete sequence (listPersesDashboardsPage.clickKebabIcon,
clickDeleteOption, deleteDashboardDeleteButton, emptyState) so the delete
targets the exact row rather than a prefix match.

web/cypress/support/perses/99.coo_rbac_perses_user5.cy.ts (1)

216-216: Consider replacing hardcoded waits with explicit assertions.

Multiple cy.wait(5000) and cy.wait(2000) calls throughout the file can lead to flaky tests. While these are pre-existing and outside this PR's scope, consider replacing them with explicit assertions or using Cypress's built-in retry-ability (e.g., cy.get().should() patterns) to wait for specific conditions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/support/perses/99.coo_rbac_perses_user5.cy.ts` at line 216,
Replace hardcoded cy.wait(5000)/cy.wait(2000) calls with explicit assertions or
network waits: locate the occurrences of cy.wait(5000) (and cy.wait(2000)) in
the test file and replace them with targeted checks such as
cy.get('<appropriate-selector>').should('<condition>') or by intercepting
network requests with cy.intercept(...) and using cy.wait('@alias') to wait for
the actual condition; update surrounding test steps (e.g., where the test
expects a UI element or API response) to use these selectors/aliases so
Cypress’s built-in retry will handle timing instead of fixed sleeps.

web/cypress/views/perses-dashboards-create-dashboard.ts (1)

67-67: Remove the fixed wait and rely on visibility assertion instead.

The cy.wait(2000) before the Cancel button visibility check is unnecessary. Cypress will wait (up to the default 4000ms timeout) for the element to become visible via the .should('be.visible') assertion, making the fixed delay redundant.

♻️ Proposed fix

-    cy.wait(2000);
     cy.byPFRole('dialog').find('button').contains('Cancel').should('be.visible').click({ force: true });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/cypress/views/perses-dashboards-create-dashboard.ts` at line 67, Remove
the hard-coded cy.wait(2000) call and rely on Cypress's built-in retry by
asserting visibility on the Cancel button instead; delete the cy.wait(2000) line
and ensure the subsequent check uses a visibility assertion like cy.get(... or
cy.contains('Cancel')).should('be.visible') (or add an explicit timeout option
if the element sometimes takes longer, e.g. .should('be.visible', { timeout:
10000 })), so the test no longer depends on a fixed delay.